Use require instead of assert in test#785
Merged
antlai-temporal merged 3 commits intotemporalio:mainfrom Mar 29, 2025
Merged
Conversation
cretz
approved these changes
Mar 28, 2025
| "--output", "json", | ||
| ) | ||
| assert.NoError(t, res.Err) | ||
| require.NoError(t, res.Err) |
Contributor
There was a problem hiding this comment.
A little concerned with the above temporal workflow update-options --query whatever above in that visibility is eventually consistent, so how do you know it found anything with that CustomKeywordField? Or are you just relying on the speed of dev server visibility that the workflow will always be in visibility by this time?
Contributor
Author
There was a problem hiding this comment.
Adding extra test for visibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
One of the versioning tests incorrectly used assert instead of require, and that did not
protect from a nil pointer panic.